1325 manage dashboard UI #1352
Open
1325 manage dashboard UI #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the manage bookmark UI
schroerbrian
commented
May 17, 2024
| src={icon(expandedOptions ? "filter-white" : "filter-gray")} | ||
| alt="Add filters to search" | ||
| <> | ||
| <div className={styles.advancedSearchContainer}> |
There was a problem hiding this comment.
I had to create a parent tag and nest the advancedSearchContainer element to include the Bookmark/Saved Search UI on the page. In other words, there are no substantive changes from lines 148–215; the only changes are tabbing to nest the element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nearly completes the UI for the Dashboard Page. Of course, the page will need to be wired up to the API endpoints when they are done.
The only pieces lacking, from a front-end perspective, is:
1. The functionality to open the Bookmarks Slider to manage bookmarks. I had initially wanted to push this off to v2, but I think that I can create the slider finish it up probably tomorrow (Friday).2. Some kind of functionality on the line icon on saved searches. I asked a question in Figma about what the line icon should do. My working assumption is that maybe it opens a dropdown menu from which the user can click delete to delete the saved search; however, I want to give design/research some time to respond.
Tomorrow, I will work on adding the Bookmark slider to this PR.
**Update: I have added the manage Bookmarks Slider. **
It is missing several features including:
I have noted these on the ticket
That said, I believe this is contained piece of work that can go out as it allows the user to view all of their folders/bookmarks in one place and to click on a bookmarked service to take them to the service. I think the remaining features can be finished prior to our launch date.