Added skeletal animation system #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsymalla
reviewed
Jul 29, 2018
| @@ -14,6 +14,7 @@ class Mesh | |||
| { | |||
| public: | |||
| Mesh(std::string identifier, Vertex vertices[], int vertSize, unsigned int indices[], int indexSize); | |||
| void reasign(std::string identifier, Vertex vertices[], int vertSize, unsigned int indices[], int indexSize); //Added by Majid | |||
Shervanator
commented
Jul 29, 2018
| m_meshData = std::make_shared<MeshData>(vertices, vertSize, indices, indexSize); | ||
| m_meshCache[identifier] = m_meshData; | ||
| } | ||
| } | ||
| void Mesh::reasign(std::string identifier, Vertex vertices[], int vertSize, unsigned int indices[], int indexSize) //Added by Majid |
There was a problem hiding this comment.
need to find out why reasign was added, as its not really used for animation from what i see
There was a problem hiding this comment.
In fact, I want to add skeletal animation to your Engine, but after some work, I figure out that the animations apply to the entities implemented by some shaders. I use "reasign" and also "recreateMesh" to apply animations (change mesh vertexes) but It should be implemented by shader. I will work on it in the future and try to implement it through shader
Shervanator
commented
Jul 29, 2018
| #endif | ||
| } | ||
|
|
||
| void MeshData::recreateMesh(Vertex *vertices, int vertSize, unsigned int *indices, int indexSize) //Added by Majid |
There was a problem hiding this comment.
same as this, what was recreateMesh added for, is it useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contribution by Majid Anjidani