[BFCL] Patch Gemini Handler #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShishirPatil
approved these changes
May 15, 2024
|
Thank you for the fix! @HuanzhiMao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on the work of @vandyxiaowei #406, this PR is a bug fix for the generation pipeline for Gemini models (Gemini-1.5-Pro (FC) and Gemini-1.0-Pro (FC)) to make it more robust. The Gemini model output
result["candidates"][0]does not always have the key"content", which would cause the current generation pipeline to error out.This PR DOES NOT change the leaderboard score.