Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some data issues in parallel/parallel multiple answers #423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vandyxiaowei
Copy link
Contributor

some parameters have default value, so it should be acceptable if the model doesn't predict the parameter. add "" in the possible answers for those cases.

Please take a look. Thanks!

Copy link
Contributor

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vandyxiaowei,

Thanks for contributing!

One minor request: Could we exclude the linting changes from this PR? This would help better highlight the changes to the possible answers. Right now the "Files changed" section indicates over 200 additions and deletions, which are predominantly whitespace alterations. These do not impact the evaluation pipeline's correctness but could obscure the actual modifications to possible answers when other people look at this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants