[HACKDAYS] ES_PREDICATES and ES_STREET_PREDICATES pipelines

[kwiersema]

Context

Hackdays POC for making full address validation logic run in the predicate pipeline

Approach

• Create a new temporary es_predicates and es_street_predicates pipelines for A/B testing
• Create the full address predicates found, zip_known, city_known, province_known, street_known
• Add the new predicates to the es_predicates and es_street_predicates pipelines
• Update validator pipeline executor flow with full address specific logic

Testing

With ES strategy:

With ES predicates strategy:

🐞 Bug fix 🐞

ES strategy has no concerns on invalid zip if a candidate is found:

ES_PREDICATES strategy will still run the zip valid checks as a final sanity check even if a candidate is found and determined to be "good"

🎩 Benchmarking results on dev_tagged suite for US 🎩

+----------------------------------------------------------+---------+
| Field                                                    | Percent |
+----------------------------------------------------------+---------+
| % of confirmed validated addresses                       | 99.4%   |
| % of validated addresses that we INCORRECTLY flagged     | 0.6%    |
| % of known invalid addresses (with CORRECT suggestion)   | 81.0%   |
| % of known invalid addresses (with INCORRECT suggestion) | 7.1%    |
| % of known invalid addresses (with no suggestion)        | 11.9%   |
+----------------------------------------------------------+---------+

vs current baseline performance of

+----------------------------------------------------------+---------+
| Field                                                    | Percent |
+----------------------------------------------------------+---------+
| % of confirmed validated addresses                       | 99.4%   |
| % of validated addresses that we INCORRECTLY flagged     | 0.6%    |
| % of known invalid addresses (with CORRECT suggestion)   | 79.8%   |
| % of known invalid addresses (with INCORRECT suggestion) | 7.1%    |
| % of known invalid addresses (with no suggestion)        | 13.1%   |
+----------------------------------------------------------+---------+

Checklist

• I have added a CHANGELOG entry for this change (or determined that it isn't needed)
• Added Sorbet signatures to new methods I've introduced
• Commits squashed

[kwiersema]

Do not execute any full address predicate if we already have local concerns.

[kwiersema]

this is the simple non multi-locale call for now. Supporting multi-locale would be a small refactor to move the logic from the best_candidate method in FullAddress to another class and call that here.

[kwiersema]

we don't need the CandidateTuple anymore since the address comparison is now initialized with the candidate.

[kwiersema]

Add the zip checks at the end of the pipeline to still return zip concerns if a candidate is not found.