-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli-kit] Support parsing multiline environment variables in .env file #3494
Conversation
This comment has been minimized.
This comment has been minimized.
a9f3e00
to
837d70b
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1580 tests passing in 737 suites. Report generated by 🧪jest coverage report action from 3affd6b |
69a1e6d
to
6351648
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of it!
Have you tested it on Windows? I'm a bit concerned about the new line logic that works differently there.
6351648
to
3affd6b
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/dot-env.d.ts@@ -32,4 +32,5 @@ export declare function writeDotEnv(file: DotEnvFile): Promise<void>;
*/
export declare function patchEnvFile(envFileContent: string | null, updatedValues: {
[key: string]: string | undefined;
-}): string;
\ No newline at end of file
+}): string;
+export declare function createDotEnvFileLine(key: string, value?: string, quote?: string): string;
\ No newline at end of file
|
|
WHY are these changes introduced?
Hydrogen CLI is introducing multiline support in their .env files
WHAT is this pull request doing?
dotenv
libraryHow to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.