Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QA scripts to support global CLI #3895

Merged
merged 4 commits into from
May 21, 2024
Merged

Update QA scripts to support global CLI #3895

merged 4 commits into from
May 21, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

As part of the release QA process we want to test that a global installation of the CLI works as expected.

WHAT is this pull request doing?

  • Add a new flag to the app QA script to install the CLI globally.
  • Install and run the global CLI when required.
  • Don't install @shopify/theme anymore

How to test your changes?

Run different combinations of node bin/create-test-app.js (with --global, -i nightly, -i experimental, ...)

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.05% 7019/9742
🟡 Branches 68.94% 3469/5032
🟡 Functions 71.49% 1881/2631
🟡 Lines 73.37% 6616/9017

Test suite run success

1649 tests passing in 766 suites.

Report generated by 🧪jest coverage report action from 40689c9

@isaacroldan isaacroldan added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 7e615db May 21, 2024
32 checks passed
@isaacroldan isaacroldan deleted the fix-qa-scripts branch May 21, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants