Renames default_placement_reference extension toml property to default_placement

[PSalmers]

WHY are these changes introduced?

Fixes https://github.com/Shopify/core-issues/issues/70722
Homogenizing the terminology to "placement" instead of "placement_reference" et al.

WHAT is this pull request doing?

Just renames the key used by developers. This is an unreleased feature (not yet enabled in core), so we want to get the terminology correct before release. Does not rename the values passed on to core.

How to test your changes?

The process is to have a local copy of CLI point at an spin instance, and then to deploy a locally developed ui extension on that instance.

• use my instance "rename-default-placement-3"

SHOPIFY_CLI_1P_DEV=1 SPIN_INSTANCE=rename-default-placement-3 SHOPIFY_SERVICE_ENV=spin pnpm create @shopify/app 

In the new app directory:

SPIN_INSTANCE=rename-default-placement-3 SHOPIFY_SERVICE_ENV=spin pnpm shopify app generate extension


Configure your extension toml to include default_placement. ex:

[[extensions.targeting]]
module = "./src/Banner.tsx"
target = "purchase.checkout.block.render"
default_placement = "order_summary2"

back in your CLI directory start the server. ex:

SPIN_INSTANCE=rename-default-placement-3 SHOPIFY_SERVICE_ENV=spin pnpm shopify app dev --path /Users/johnking/src/github.com/Shopify/cli/default-placements 

deploy the app

SPIN_INSTANCE=rename-default-placement-3 SHOPIFY_SERVICE_ENV=spin pnpm shopify app deploy --path /Users/johnking/src/github.com/Shopify/cli/default-placements 

The app should deploy successfully. Or if you use an invalid value for default_placement you should get an error.

Post-release steps

n/a

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/app-management

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	71.83%	7127/9922
🟡	Branches	69.12%	3519/5091
🟡	Functions	71.47%	1906/2667
🟡	Lines	73.1%	6708/9177

Test suite run success

1662 tests passing in 771 suites.

Report generated by 🧪jest coverage report action from 95d5343

[oluwatimio]

Was this already changed in core?

[PSalmers]

No, this is separate from the core changes for which I have created an issue here https://github.com/orgs/Shopify/projects/3111/views/88?pane=issue&itemId=64006155

This PR just aliases "default_placement" in the toml to "default_placement_reference" when it passes it to the backend.

[oluwatimio]

Makes sense!

[oluwatimio]

Make sure to add a changeset before you ship this PR