Prompt to convert dev stores to transfer-disabled

[shauns]

WHY are these changes introduced?

Closes https://github.com/Shopify/develop-app-management/issues/1785

WHAT is this pull request doing?

In the usual place where a dev store is selected, prompt prior to converting it to transfer-disabled (where that is required). The user can choose to select a different store if needed.

How to test your changes?

Internal video: https://share.descript.com/view/QtyPwXjPLEu (has a small snag which is corrected now)

• Create a dev store on partners. Choose the left-hand option, not the "I want to test apps" option. Give it a minute or so to become real, and follow the login prompt partners will send you to.
• Run p shopify app dev --reset and select that store.
• See the new warning

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/app-management

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	71.96% (+0% 🔼)	7033/9774
🟡	Branches	68.8% (+0.01% 🔼)	3482/5061
🟡	Functions	71.44% (-0.03% 🔻)	1881/2633
🟡	Lines	73.27% (+0% 🔼)	6631/9050

Show new covered files 🐣

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / convert_dev_to_transfer_disabled_store.ts	100%	100%	100%	100%

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟡	... / dev.ts	74.42% (-1.77% 🔻)	56.25%	76.47% (-4.78% 🔻)	69.44% (-1.98% 🔻)
🟢	... / select-store.ts	86% (-1.5% 🔻)	81.82% (-5.68% 🔻)	85.71%	87.23% (-1.65% 🔻)
🔴	... / partners-client.ts	19.8%	33.33% (-1.28% 🔻)	15.56%	19.79%

Test suite run success

1650 tests passing in 766 suites.

Report generated by 🧪jest coverage report action from fb3433b

[isaacroldan]

Just a small comment