Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Render deprecation warning when poll flag is provided to TS dev command #3903

Merged
merged 1 commit into from
May 17, 2024

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented May 16, 2024

WHY are these changes introduced?

WHAT is this pull request doing?

Renders a warning to the user when they provide the poll flag in the TS flow

Screenshot 2024-05-16 at 10 11 24 AM

How to test your changes?

pnpm shopify theme dev --path=<PATH_TO_THEME> --dev-preview --poll

If you run into issues on the build step relating to authentication, you may need to remove app-management from allAPIs in packages/cli-kit/src/private/node/api.ts

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@jamesmengo jamesmengo added the #gsd:40767 Fortify local development experience for Liquid themes label May 16, 2024
@jamesmengo jamesmengo self-assigned this May 16, 2024
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@jamesmengo jamesmengo requested a review from karreiro May 16, 2024 17:14
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.96% (-0.01% 🔻)
7025/9763
🟡 Branches
68.8% (-0.01% 🔻)
3477/5054
🟡 Functions 71.47% 1881/2632
🟡 Lines
73.27% (-0.01% 🔻)
6622/9038
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / partners-client.ts
19.8%
33.33% (-1.28% 🔻)
15.56% 19.79%
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1649 tests passing in 766 suites.

Report generated by 🧪jest coverage report action from b4fd01b

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jamesmengo!

@jamesmengo jamesmengo added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit e812413 May 17, 2024
33 checks passed
@jamesmengo jamesmengo deleted the jmeng/poll_warn branch May 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:40767 Fortify local development experience for Liquid themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants