Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required node version to be compatible with M1 macs #754

Merged
merged 1 commit into from Nov 9, 2022

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Nov 9, 2022

WHY are these changes introduced?

Fixes #697

Node 14 has issues with M1s, which were solved in 14.17, see nodejs/node#38051

WHAT is this pull request doing?

Updates all packages to depend on a Node version compatible with M1 macs.

How to test your changes?

Shouldn't require testing AFAICT

Post-release steps

Need to update the docs that mention Node 14.13.1 to Node 14.17.0

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Node 14 has issues with M1s, which were solved in 14.17, see
nodejs/node#38051
@amcaplan amcaplan requested a review from a team November 9, 2022 16:08
@amcaplan amcaplan requested review from a team as code owners November 9, 2022 16:08
@amcaplan amcaplan merged commit 2665060 into main Nov 9, 2022
@amcaplan amcaplan deleted the update-node-version-requirement branch November 9, 2022 19:33
@shopify-shipit shopify-shipit bot temporarily deployed to production November 14, 2022 14:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: All Shopify cli commands yield no result at all on macOS 13 Ventura
4 participants