Skip to content
🚀 CI

[Breaking Change] Remove session.commit everywhere and instead do it in server before returning the new response. #4935

Sign in to view logs

[Breaking Change] Remove session.commit everywhere and instead do it in server before returning the new response.

[Breaking Change] Remove session.commit everywhere and instead do it in server before returning the new response. #4935

Triggered via pull request May 21, 2024 20:59
@michenlymichenly
synchronize #2137
dirty-session
Status Failure
Total duration 3m 21s
Artifacts –

ci.yml

on: pull_request
⬣ ESLint
1m 23s
⬣ ESLint
⬣ Prettier
56s
⬣ Prettier
Typescript
2m 49s
Typescript
⬣ Unit tests
3m 9s
⬣ Unit tests
Fit to window
Zoom out
Zoom in

Annotations

6 errors
Typescript
Type 'AppSession' is not assignable to type 'HydrogenSession<SessionData, any>'.
Typescript
Property 'dirty' in type 'AppSession' is not assignable to the same property in base type 'HydrogenSession<SessionData, any>'.
Typescript
example-custom-cart-method#typecheck: command (/home/runner/work/hydrogen/hydrogen/examples/custom-cart-method) /opt/hostedtoolcache/node/18.20.2/x64/bin/npm run typecheck exited (1)
Typescript
Process completed with exit code 1.
⬣ Unit tests
@shopify/hydrogen#test: command (/home/runner/work/hydrogen/hydrogen/packages/hydrogen) /opt/hostedtoolcache/node/18.20.2/x64/bin/npm run test exited (1)
⬣ Unit tests
Process completed with exit code 1.