Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IndexFilters | Tabs] Add prefix prop to IndexFilters and readonly prop to Tab. #11869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrcthms
Copy link
Contributor

@mrcthms mrcthms commented Apr 9, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/web/issues/123422

The Markets team need some updates to the IndexFilters and Tabs components to support the new UI that they are building.

WHAT is this pull request doing?

This PR adds a prefix prop to the IndexFilters, which will render the ReactNode passed as the prop immediately to the left of the Tabs within the IndexFilters.

It also adds a new readonly prop to a Tab within the Tabs component, which will give the Tab a differing visual treatment, and remove any interactivity from the Tab itself.

Screenshot 2024-04-09 at 10 50 35

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@mrcthms
Copy link
Contributor Author

mrcthms commented Apr 9, 2024

/snapit

Copy link
Contributor

github-actions bot commented Apr 9, 2024

🫰✨ Thanks @mrcthms! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240409095421"

Copy link

@Michael-Frangione Michael-Frangione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for adding these features.

@aaronccasanova aaronccasanova force-pushed the mrcthms-index-filters-prefix-tab-readonly branch from 38d8648 to d06ed25 Compare April 19, 2024 21:52
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 19, 2024
@translation-platform
Copy link
Contributor

Localization quality issues found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Clear for key Polaris.ActionList.SearchField.clearButtonLabel is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
  • The value Search for key Polaris.ActionList.SearchField.search is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
  • The value Search actions for key Polaris.ActionList.SearchField.placeholder is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-needed Added by a bot. Contributor needs to sign the CLA Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants