New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sewing-kit bump #2369
Sewing-kit bump #2369
Changes from all commits
16e3b1f
698f1fb
621ce25
66c67cc
ae91970
17b72b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,14 +55,36 @@ | |
"jsx-a11y/mouse-events-have-key-events": "off", | ||
"jsx-a11y/click-events-have-key-events": "off", | ||
"jsx-a11y/no-noninteractive-element-interactions": "off", | ||
"jsx-a11y/no-noninteractive-element-to-interactive-role": "off" | ||
"jsx-a11y/no-noninteractive-element-to-interactive-role": "off", | ||
"@typescript-eslint/camelcase": [ | ||
"error", | ||
{ | ||
"allow": [ | ||
"UNSTABLE_Color", | ||
"UNSTABLE_colors", | ||
"UNSTABLE_cssCustomProperties", | ||
"UNSTABLE_telemetry" | ||
] | ||
} | ||
] | ||
}, | ||
"overrides": [ | ||
{ | ||
"files": ["src/**/*.{ts,tsx}"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because some of our ts files aren't included in our tsconfig's files list we can't set this stuff at the global level, which is a little annoying but not the end of the world. |
||
"extends": ["plugin:shopify/typescript-type-checking"], | ||
"parserOptions": { | ||
"project": "./tsconfig.json" | ||
}, | ||
"rules": { | ||
"@typescript-eslint/prefer-readonly": "off", | ||
"@typescript-eslint/no-unnecessary-condition": "off", | ||
"@typescript-eslint/unbound-method": "off" | ||
} | ||
}, | ||
{ | ||
"files": ["**/*.test.{ts,tsx}"], | ||
"rules": { | ||
"jest/no-truthy-falsy": "off", | ||
"shopify/jsx-no-hardcoded-content": "off", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is now turned off in tests by default |
||
"shopify/no-ancestor-directory-import": "off" | ||
} | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ const Components = ({components, status}) => ( | |
<React.Fragment> | ||
{status === 'loading' && ( | ||
<Box marginLeft={4} marginBottom={1}> | ||
⏳{' '}Please wait during compilation… Beep boop beep 🤖 | ||
⏳ Please wait during compilation… Beep boop beep 🤖 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No regression here – all good. |
||
</Box> | ||
)} | ||
|
||
|
@@ -202,8 +202,8 @@ const App = () => { | |
<Color dim> | ||
<Box width={3}>💡</Box> | ||
<Box> | ||
Tip: to disable these reports, run{' '} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<Text bold>DISABLE_SPLASH=1 yarn dev</Text> | ||
Tip: to disable these reports, run | ||
<Text bold> DISABLE_SPLASH=1 yarn dev</Text> | ||
</Box> | ||
</Color> | ||
</Box> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ describe('<AppProvider />', () => { | |
}); | ||
|
||
it('updates context when props change', () => { | ||
const Child: React.SFC<{}> = () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A lot of the changes in this PR are "that's the default value for the generic, you don't need to specify that" |
||
const Child: React.SFC = () => { | ||
return useContext(LinkContext) ? <div id="child" /> : null; | ||
}; | ||
const LinkComponent = () => <div />; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,6 @@ export interface ToastManagerProps { | |
toastMessages: (ToastPropsWithID)[]; | ||
} | ||
|
||
// This does have a display name, but the linting has a bug in it | ||
// https://github.com/yannickcr/eslint-plugin-react/issues/2324 | ||
// eslint-disable-next-line react/display-name | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 🔥 |
||
export const ToastManager = memo(function ToastManager({ | ||
toastMessages, | ||
}: ToastManagerProps) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit nicer than sprinkling single-line ignores throughout the codebase