Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[polaris.shopify.com] Add playroom prototype #7032

Merged
merged 31 commits into from Oct 14, 2022

Conversation

gwyneplaine
Copy link
Contributor

@gwyneplaine gwyneplaine commented Aug 26, 2022

WHY are these changes introduced?

This PR is the core PR for the composite component tooling project.

WHAT is this pull request doing?

At a high level the changes include:

  • Adding a playroom integration to polaris.shopify.com
    • On dev this spins up a separate dev server that the core next app redirects to on hitting the route /playroom
    • In prod this can all be run statically, build builds assets to the public/playroom folder of the core polaris.shopify.com next app.
  • Added a /sandbox route for branding and guidance
  • Made changes to playroom src via patch-package to allow us to apply code transforms before playroom runs its own transforms via babel.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

  • Run yarn workspace polaris.shopify.com dev on the root of the repo
  • Visit the sandbox route at localhost:3000/sandbox
  • Play with the editor

🎩 checklist

@ghost
Copy link

ghost commented Aug 26, 2022

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

size-limit report 📦

Path Size
polaris-react-cjs 200.77 KB (+0.01% 🔺)
polaris-react-esm 128.94 KB (+0.01% 🔺)
polaris-react-esnext 183.06 KB (+0.01% 🔺)
polaris-react-css 40.61 KB (0%)

@gwyneplaine
Copy link
Contributor Author

/snapit

@gwyneplaine gwyneplaine force-pushed the prototype-composition-tooling branch 4 times, most recently from 13a69bd to 9cf90fc Compare August 26, 2022 05:33
@Shopify Shopify deleted a comment from netlify bot Sep 13, 2022
@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 754e5f9fb93df0074c5a0a36709e4671a45075e1 is now deploying to staging. View status.

@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 754e5f9fb93df0074c5a0a36709e4671a45075e1 is now deploying to staging. View status.

@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 5d9518329f5ea00be5d9e6a01c870593615d0029 is now deploying to staging. View status.

@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 5d9518329f5ea00be5d9e6a01c870593615d0029 is now deploying to staging. View status.

@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 1c6bff4c19fa1ff384e7fd454277335bf0f01018 is now deploying to staging. View status.

@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 7c461ce4a0a5bcb4a1765c9355d779e7032f9d91 is now deploying to staging. View status.

@jesstelford
Copy link
Contributor

/stageit

@github-actions
Copy link
Contributor

🚀 54baebc23703ac60cf5434aeda5dc21dfba603b4 is now deploying to staging. View status.

@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 18e3c342744dc846085af687e644cefd13a63a9e is now deploying to staging. View status.

@gwyneplaine gwyneplaine force-pushed the prototype-composition-tooling branch 2 times, most recently from 6030387 to 813c3ff Compare September 26, 2022 07:40
@gwyneplaine
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

🚀 813c3ff31e671f243395d6236497f2b06bbabb3d is now deploying to staging. View status.

@gwyneplaine gwyneplaine dismissed martenbjork’s stale review October 13, 2022 22:55

All feedback actions resolved or deferred to separate PRs

@gwyneplaine gwyneplaine merged commit 40ee692 into main Oct 14, 2022
@gwyneplaine gwyneplaine deleted the prototype-composition-tooling branch October 14, 2022 00:10
@github-actions github-actions bot mentioned this pull request Oct 14, 2022
kyledurand pushed a commit that referenced this pull request Oct 14, 2022
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.5.0

### Minor Changes

- [#7373](#7373)
[`56c82ee8d`](56c82ee)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add
`getFunctionArgs` utility

### Patch Changes

- Updated dependencies
\[[`c3f427c17`](c3f427c)]:
    -   @shopify/polaris-tokens@6.2.1

## @shopify/polaris@10.8.0

### Minor Changes

- [#7364](#7364)
[`e4b2c36d8`](e4b2c36)
Thanks [@Bringer128](https://github.com/Bringer128)! - Deprecated
Collapsible preventMeasuringOnChildrenUpdate.
Fixed bug where Collapsible would get stuck in animating state when
duration is 0.
Add support for intentionally disabling the transition in Collapsible.

### Patch Changes

- [#7363](#7363)
[`8a6c323e2`](8a6c323)
Thanks [@aveline](https://github.com/aveline)! - Added `id` prop to
`Text` and `Box`


- [#7348](#7348)
[`ea2a45bbb`](ea2a45b)
Thanks [@aveline](https://github.com/aveline)! - Added `setMediaWidth`
breakpoints test utility


- [#7388](#7388)
[`5bc885765`](5bc8857)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a re-render
bug with Page Actions

- Updated dependencies
\[[`c3f427c17`](c3f427c)]:
    -   @shopify/polaris-tokens@6.2.1

## @shopify/plugin-polaris@0.0.11

### Patch Changes

- Updated dependencies
\[[`56c82ee8d`](56c82ee)]:
    -   @shopify/polaris-migrator@0.5.0

## @shopify/polaris-tokens@6.2.1

### Patch Changes

- [#7385](#7385)
[`c3f427c17`](c3f427c)
Thanks [@laurkim](https://github.com/laurkim)! - Refactored exported
alias and scale types in `breakpoints`, `depth`, `font`, `motion`,
`shape`, `spacing`, and `zIndex`.

## @shopify/stylelint-polaris@4.3.2

### Patch Changes

- Updated dependencies
\[[`c3f427c17`](c3f427c)]:
    -   @shopify/polaris-tokens@6.2.1

## polaris.shopify.com@0.22.0

### Minor Changes

- [#7032](#7032)
[`40ee692aa`](40ee692)
Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Added Playroom
integration to Polaris docs site.

### Patch Changes

- [#7032](#7032)
[`40ee692aa`](40ee692)
Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Improved the
design of the Sandbox feature.


- [#7400](#7400)
[`9f9fe1f99`](9f9fe1f)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a scaling
bug caused by content overflow
Fixed a bug where examples that don't have any content wouldn't show up
- Updated dependencies
\[[`8a6c323e2`](8a6c323),
[`e4b2c36d8`](e4b2c36),
[`c3f427c17`](c3f427c),
[`ea2a45bbb`](ea2a45b),
[`5bc885765`](5bc8857)]:
    -   @shopify/polaris@10.8.0
    -   @shopify/polaris-tokens@6.2.1

## polaris-for-figma@0.0.24

### Patch Changes

- Updated dependencies
\[[`8a6c323e2`](8a6c323),
[`e4b2c36d8`](e4b2c36),
[`ea2a45bbb`](ea2a45b),
[`5bc885765`](5bc8857)]:
    -   @shopify/polaris@10.8.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants