Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Banner] [Card] [Modal] convert banner legacy context API to use create context #786

Merged
merged 1 commit into from
Jan 11, 2019
Merged

[Banner] [Card] [Modal] convert banner legacy context API to use create context #786

merged 1 commit into from
Jan 11, 2019

Conversation

danrosenthal
Copy link
Contributor

@danrosenthal danrosenthal commented Dec 20, 2018 •
edited

@BPScott BPScott temporarily deployed to polaris-react-pr-786 December 20, 2018 15:28 Inactive
@danrosenthal danrosenthal changed the title [Banner] [Card] [Modal] convert banner withintContentContext to use modern Context API [WIP] [Banner] [Card] [Modal] convert banner withintContentContext to use modern Context API Dec 20, 2018
@kaelig
Copy link
Contributor

kaelig commented Dec 20, 2018

Yay! Our first item under the new "Code quality" changelog category :)

@BPScott BPScott temporarily deployed to polaris-react-pr-786 December 20, 2018 21:29 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-786 December 20, 2018 21:34 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-786 December 20, 2018 21:37 Inactive
@danrosenthal danrosenthal changed the title [WIP] [Banner] [Card] [Modal] convert banner withintContentContext to use modern Context API [Banner] [Card] [Modal] convert banner withintContentContext to use modern Context API Dec 20, 2018
@danrosenthal danrosenthal changed the title [Banner] [Card] [Modal] convert banner withintContentContext to use modern Context API [Banner] [Card] [Modal] convert banner withinContentContainer to use modern Context API Dec 21, 2018
@danrosenthal danrosenthal changed the title [Banner] [Card] [Modal] convert banner withinContentContainer to use modern Context API [Banner] [Card] [Modal] convert banner legacy context API to use create context Dec 21, 2018
AndrewMusgrave
AndrewMusgrave approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the 🎩 links 🎉 LGTM, left a small nitpick and it might need a commit squash 💯

Sidenote soon we won't need to pass generics too all our HoC

src/components/Banner/Banner.tsx Outdated Show resolved Hide resolved
src/components/Banner/Banner.tsx Outdated Show resolved Hide resolved
dleroux
dleroux approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚢 following Andrews suggestion.

@BPScott BPScott requested a deployment to polaris-react-pr-786 January 11, 2019 15:49 Abandoned
@danrosenthal danrosenthal merged commit e88e1a9 into master Jan 11, 2019
@danrosenthal danrosenthal deleted the refactor-legacy-banner-context branch January 11, 2019 15:54
@danrosenthal danrosenthal mentioned this pull request Jan 16, 2019
Merged
@danrosenthal danrosenthal temporarily deployed to production January 16, 2019 18:10 Inactive
@danrosenthal danrosenthal mentioned this pull request Jan 16, 2019
Merged
danrosenthal added a commit that referenced this pull request Jan 16, 2019
@danrosenthal
Merge pull request #884 from Shopify/reexport-content-context-types
8071acc 
revert [Banner] [Card] [Modal] convert banner legacy context API to use create context #786
danrosenthal added a commit that referenced this pull request Jan 18, 2019
@danrosenthal
Revert "revert [Banner] [Card] [Modal] convert banner legacy context …
ddf8a91 
…API to use create context #786"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfmcphee dfmcphee dfmcphee approved these changes

@dleroux dleroux dleroux approved these changes

@AndrewMusgrave AndrewMusgrave AndrewMusgrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danrosenthal @kaelig @dfmcphee @dleroux @AndrewMusgrave @BPScott