Restructure repo to report on missing dependencies #1026
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1001
The changes in this PR allow us to turn on the eslint rule no-extraneous-dependencies. This is a big change so I'm breaking down the three major things happening here:
I moved all of the packages to
packages/@shopify
to allow the eslint rule to recognize the packages in this repository properly. More context in this issue Prevent missing@shopify/*
packages from going out to releases #1001Adjusted our
.eslintrc
to automatically populate the overrides for each package in this repo to only look locally in that package for existing dependencies.With the above 2 changes, it now successfully reporting errors and the final changes are me retro-actively applying the missing dependencies for the ~200 times we broke this rule, but got lucky in that it didn't break anything.
Additional things
devDependencies: true, optionalDependencies: false, peerDependencies: true,
as it seemed like the best way to accommodate the missingreact
/react-dom
dependencies across this repo.quilt
framework more easily which I agree with.