Support jest 18 transformer requirements #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilsonperkin
force-pushed
the
support-jest-18-transformer-requirements
branch
from
540c158
to
520739c
Compare
In Jest <=v27 it was expected that the transformed source would return an object with a code property containing the transformed code, but it was accepted as a shortcut to just return a string. Jest 28 makes the code object a strict requirement and simple string returns are no longer accepted.
ryanwilsonperkin
force-pushed
the
support-jest-18-transformer-requirements
branch
from
520739c
to
ec6fd07
Compare
vsumner
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jest v28 has just been released and one breaking change requires that all Jest transformers must match a stricter signature. Specifically, the
processwas previously allowed to return either an object of shape{code: string}or juststring, it has now been narrowed to only support the{code: string}approach.See: jestjs/jest#12638
Type of change
expected)
Checklist