-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLS to performance & koa-performance #2576
base: main
Are you sure you want to change the base?
Conversation
a47b54d
to
0e831c8
Compare
Sorry for the delay on this folks, I know its getting stale. I'll get to this again this week I hope. |
Do we care about commit organization in quilt? Wondering if it'd be valid to squash the commits into a single one before merging. |
Is this PR moving forward or should we close it? I was hoping to stop getting daily notifications from it 😅 |
Ahh I'm sorry about that! This is on me, if I don't have it in a good state in a day or two I'll close it. Sorry for the spam! |
3f30837
to
a096449
Compare
I've squashed the commits and updated the readme. This is ready for review now. If you have a few minutes @ryanwilsonperkin @lucabezerra please have another look and let me know if it looks okay, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, thanks for circling back to this!
From my end it looks ok, but since @ryanwilsonperkin flagged the issue, let's wait for him to say something :)
Description
This is a (perhaps naive) attempt to add cumulative layout shift to the
performance
andkoa-performance
packages.Only did a patch bump as this shouldn't be a breaking change, the new metric should be included seamlessly for any consumers that choose to upgrade to this version.
Fixes (issue #)
https://github.com/Shopify/opentelemetry-js/issues/156