-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize Ruby Version to .ruby-version
#1339
Conversation
dev.yml reads from .ruby-version
.rubocop_todo.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a RuboCop TODO for now. I created a PR to fix these violations here #1340
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just stop bumping rubocop in open source repos, it always creates a mess.
These PRs ought to be simple changes, I don't want tons of rubocop pedantry with them.
.rubocop.yml
Outdated
AllCops: | ||
TargetRubyVersion: 3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this?
A
This should not apply to open source nor to libraries in general. Contrary to apps, they support multiple Ruby versions. |
In RuboCop 1.61.0, this value will be read from If you do not want to update Rubocop for this feature due to the other changes it causes, I'll remove the changes related to RuboCop. |
it will be read from .ruby-version
d7bd4cf
to
42c242c
Compare
Yeah it's fine, let's keep a minor duplication for now. I'll update Rubocop when it makes sense. |
Sweet! I removed the Rubocop bump ✅ |
What are you trying to accomplish?
The
.ruby-version
file is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-version
file, ensures arequired_ruby_version
is set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-version
file is present with the correct Ruby version definedrequired_ruby_version
in your gemspec is setdev.yml
Ruby task (before:- ruby: x.x.x
, after:- ruby
)Gemfile
(no lines withruby <some-version>
)Gemfile.lock
is built with the defined Ruby versionTargetRubyVersion
defined inrubocop.yml
(reads fromrequired_ruby_version
on Rubocop 1.61.0)ruby/setup-ruby
Github Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”
)To establish consistency, the
required_ruby_version
is set to 3.0. If you think that another version is a better fit, please make the applicable changes.Please merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.