Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce promise based idempotent job handler to ensure after auth hook is only called once #511

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Introduce promise based idempotent job handler to ensure after auth hook is only called once #511

wants to merge 26 commits into from
+1,056 −198

Conversation

rezaansyed
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

rachel-carvalho and others added 20 commits December 4, 2023 14:54
@rachel-carvalho @rezaansyed
add unstable_newEmbeddedAuthStrateg future flag
d168f0e
@rachel-carvalho @rezaansyed
add token exchange strategy
a4c77df
@rezaansyed
Comment out param deletion as it broke /session-token
0935433
@rezaansyed
Enable token exchange strategy when future flag is enabled
880e467
@rachel-carvalho @rezaansyed
setup auth code flow tests with future flag off
7e821f5
@rachel-carvalho @rezaansyed
remove duplicated auth code flow folder
9406583
@rachel-carvalho @rezaansyed
add tests to token exchange strategy
0b1dfc2
@rachel-carvalho @rezaansyed
move tests that redirect when no session is found into auth code flow…
2eb76ee 
… test folder
@rachel-carvalho @rezaansyed
move embedded search param check to generic doc request tests
9c3c2d6
@rezaansyed
Check the number of token exchange calls made in tests
a2c3e55
@rezaansyed
throw 500 for most token exchange errors and complete code coverage
b83523e
@rezaansyed
Fix logging
79ab147
@rezaansyed
Update types to account for unstable_tokenExchange and unstable_newEm…
3839ad1 
…beddedAuthStrategy future flags
@rezaansyed
Add changeset
3b2b0a6
@rezaansyed
Update future flag description
cb07dc1
@rezaansyed
Log throttling errors on webhook registration
bfc0a86
@rezaansyed
Refactor setUpValidSession interface
d75b8c9
@rezaansyed
Remove testConfigAuthCodeFlow
1cc8357
@rezaansyed
Rename MockApiConfig to ApiConfigWithFutureFlags
483a515
@rezaansyed
Refactor based on comments
5ed5a2f
Base automatically changed from add_token_exchange to feature/token-exchange December 7, 2023 16:22
@rezaansyed rezaansyed force-pushed the feature/token-exchange branch 2 times, most recently from 8e7c99c to cd99a7a Compare December 12, 2023 16:01
@rezaansyed rezaansyed force-pushed the feature/token-exchange branch 2 times, most recently from c4fb5fb to 4683a0e Compare January 17, 2024 18:26
Base automatically changed from feature/token-exchange to main January 17, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rezaansyed @rachel-carvalho