[WIP] Fix server-side rendering for App Bridge v4 #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sle-c
reviewed
May 7, 2024
| .send( | ||
| readFileSync(join(STATIC_PATH, "index.html")) | ||
| .toString() | ||
| .replace("%VITE_SHOPIFY_API_KEY%", process.env.SHOPIFY_API_KEY || "") |
There was a problem hiding this comment.
instead of replacing string like this, can we use the define config for SHOPIFY_API_KEY like
define: {
'import.meta.env.SHOPIFY_API_KEY': process.env.SHOPIFY_API_KEY
}
There was a problem hiding this comment.
No, that's we had before, but it only affects the pages that vite builds - this call is rendering the file in the server for the initial page load.
The problem is that this value needs to be set by the time the FE loads, so replacing it there is too late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
As part of updating the template to use App Bridge React v4, we'll need to include the api key in the
index.htmlfile, which is served by the backend of the app.Vite will handle replacing it in client-side renders, which is why the variable needs to start with a
VITE_.WHAT is this pull request doing?
Dynamically replacing the api key when serving that file.