Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite to fix client pinging behind a proxy on WS disconnect #769

Merged

Conversation

jsullivan5
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

The current version of Vite in this project has a bug where when changes occur in the API behind a proxy (as in our case here), Vite pings the dev server to check the connection which is momentarily not running and throws an uncaught exception. This requires a manual refresh of the page which looks like this in the Shopify Admin:

image

This was making it difficult to extend the API in the app. I was constantly manually reloading the page.

WHAT is this pull request doing?

This updates Vite from 2.8.6 to 2.9.1 to incorporate these changes: vitejs/vite#5466 which address this issue. The API still reloads and goes through the auth process, but the manual refresh is no longer needed. :)

This doesn't violate any peer dependencies
image

Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think the yarn.lock needs to be updated and then we can merge this :)

@jsullivan5
Copy link
Contributor Author

Thanks @JaKXz I just pushed it :)

@JaKXz
Copy link
Contributor

JaKXz commented Apr 7, 2022

@jsullivan5 could you also try committing the result of npx yarn-deduplicate yarn.lock?

Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsullivan5!

@JaKXz JaKXz merged commit 8fd4a8b into Shopify:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants