Skip to content

Commit

Permalink
Update lib/target for base/dom configs to target es2020
Browse files Browse the repository at this point in the history
The functionality in esnext.asynciterable was standardised and is
included in es2018
  • Loading branch information
BPScott committed Jun 11, 2021
1 parent 5899cea commit 5dfc204
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
6 changes: 5 additions & 1 deletion packages/typescript-configs/CHANGELOG.md
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

Increased the target and lib definitions to es2020 in both `base.json` and `dom.json`. This allows for a greater range of standard features to be defined and used. We expect typescript will be ran through Babel to downlevel/polyfill all features required for your target environment [[#239](https://github.com/Shopify/web-configs/pull/239)]

## 4.0.0 - 2021-02-24

Expand Down
2 changes: 1 addition & 1 deletion packages/typescript-configs/base.json
Expand Up @@ -4,7 +4,7 @@
"esModuleInterop": true,
"isolatedModules": true,
"experimentalDecorators": true,
"lib": ["dom", "es2018", "esnext.asynciterable"],
"lib": ["dom", "es2020"],
"moduleResolution": "node",
"noUnusedLocals": true,
"noUnusedParameters": true,
Expand Down
7 changes: 3 additions & 4 deletions packages/typescript-configs/dom.json
Expand Up @@ -5,12 +5,11 @@
"lib": [
"dom",
"dom.iterable",
"es2017",
"esnext.asynciterable",
"scripthost"
"scripthost",
"es2020"
],
"module": "esnext",
"target": "es2017"
"target": "es2020"
},
"files": ["./definitions/images.d.ts", "./definitions/styles.d.ts"]
}

0 comments on commit 5dfc204

Please sign in to comment.