New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lib for base/dom TS configs to target es2020 #239
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,12 +5,11 @@ | |
"lib": [ | ||
"dom", | ||
"dom.iterable", | ||
"es2017", | ||
"esnext.asynciterable", | ||
"scripthost" | ||
"scripthost", | ||
"es2020" | ||
], | ||
"module": "esnext", | ||
"target": "es2017" | ||
"target": "es2020" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ES2017 is still the best compilation target for modern browsers (supported by 95% of user agents), as it can be served without further transpiling using What I'm trying to say is that by keeping the target to ES2017, we're removing the need for a transpiler such as babel in most cases. What am I missing here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't want Ideally There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, that makes sense! |
||
}, | ||
"files": ["./definitions/images.d.ts", "./definitions/styles.d.ts"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅