Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated npm deps #927

Merged
merged 3 commits into from
Feb 4, 2016
Merged

updated npm deps #927

merged 3 commits into from
Feb 4, 2016

Conversation

OmgImAlexis
Copy link
Collaborator

For reference this is the command to update the packages properly.
It checks if there's outdated deps and then updates and saves them as devDependencies.

npm outdated --depth=0 | grep -v Package | awk '{print $1}' | xargs -I% npm install %@latest --save-dev

@SickRage2
Copy link
Contributor

Thanks for the pull request! Before a real human comes by, please make sure your PR has all of the below criteria checked

  • Give a description on what the PR is for.
  • Make sure your PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review

Please make sure you also read contribution guide and followed all of the steps.

Thanks!

@miigotu
Copy link
Contributor

miigotu commented Feb 4, 2016

Update available: 1.6.9 (current: 1.6.7)
Run npm install -g bower to update.

maybe this?

@OmgImAlexis
Copy link
Collaborator Author

That's still not causing the issue though.

Edit: Shouldn't it update since npm install -g bower is run when travis starts?

@miigotu
Copy link
Contributor

miigotu commented Feb 4, 2016

Maybe this? wanted: {"node":">=0.12"} (current: {"node":"0.10.36","npm":"1.4.28"}) (for many packages)
There are also a few deprecated packages.

@OmgImAlexis
Copy link
Collaborator Author

None of that causes the error and that's normal as some of the packages we use have deps that're outdated.

Is there a way to have travis clear the cached files?

@miigotu
Copy link
Contributor

miigotu commented Feb 4, 2016

I already did clear all of the build caches, didnt help

npm ERR! 404 'remy/npm-tree' is not in the npm registry. npm ERR! 404 You should bug the author to publish it npm ERR! 404 It was specified as a dependency of 'snyk-resolve-deps'

@OmgImAlexis
Copy link
Collaborator Author

How come it's not failing one of the travis builds on the other PR though? Sounds like it might be a travis issue somewhere.

It's building fine for me. Is travis using npm 3.5.2?

@miigotu
Copy link
Contributor

miigotu commented Feb 4, 2016

node -v v0.10.36
npm -v 1.4.28

The other PR is where it started failing, the npm index changed between builds.

@OmgImAlexis
Copy link
Collaborator Author

Maybe it's a travis issue then.

travis-ci/travis-ci#5562

This is bad... how did it get broken?
@miigotu
Copy link
Contributor

miigotu commented Feb 4, 2016

@OmgImAlexis I dont understand why the js was this broken all of a sudden, stuff used before it was defined? Is this maybe new stuff jshint was picking up that it didnt with an older version? Is what I did ok?

@miigotu
Copy link
Contributor

miigotu commented Feb 4, 2016

Anyways, this looks fine too me, I specified node 0.12 to get it working, and just moved the function defs to just before they are used (I assume grunt-contrib-jshint update made that necessary)

I'm going to merge this, feel free to revert if it is wrong, or fix if I did something wrong, but I need the other builds in other PRs working =P

miigotu added a commit that referenced this pull request Feb 4, 2016
@miigotu miigotu merged commit d3dc337 into develop Feb 4, 2016
@miigotu miigotu deleted the npm-update branch February 4, 2016 11:45
@@ -9,7 +9,12 @@ branches:
except:
- master

env:
- TRAVIS_NODE_VERSION="0.12"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using node 5.0.0 not 0.12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll PR that change and see what happens =P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming it was installed since enterprise is still using v0.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants