-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated npm deps #927
updated npm deps #927
Conversation
Thanks for the pull request! Before a real human comes by, please make sure your PR has all of the below criteria checked
Please make sure you also read contribution guide and followed all of the steps. Thanks! |
Update available: 1.6.9 (current: 1.6.7) maybe this? |
That's still not causing the issue though. Edit: Shouldn't it update since |
f760004
to
68df04a
Compare
Maybe this? |
None of that causes the error and that's normal as some of the packages we use have deps that're outdated. Is there a way to have travis clear the cached files? |
I already did clear all of the build caches, didnt help
|
How come it's not failing one of the travis builds on the other PR though? Sounds like it might be a travis issue somewhere. It's building fine for me. Is travis using npm 3.5.2? |
node -v v0.10.36 The other PR is where it started failing, the npm index changed between builds. |
Maybe it's a travis issue then. |
This is bad... how did it get broken?
@OmgImAlexis I dont understand why the js was this broken all of a sudden, stuff used before it was defined? Is this maybe new stuff jshint was picking up that it didnt with an older version? Is what I did ok? |
Anyways, this looks fine too me, I specified node 0.12 to get it working, and just moved the function defs to just before they are used (I assume grunt-contrib-jshint update made that necessary) I'm going to merge this, feel free to revert if it is wrong, or fix if I did something wrong, but I need the other builds in other PRs working =P |
@@ -9,7 +9,12 @@ branches: | |||
except: | |||
- master | |||
|
|||
env: | |||
- TRAVIS_NODE_VERSION="0.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using node 5.0.0
not 0.12
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll PR that change and see what happens =P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming it was installed since enterprise is still using v0.12
.
For reference this is the command to update the packages properly.
It checks if there's outdated deps and then updates and saves them as
devDependencies
.