New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow using the consistent naming with the signoz collector #4865
base: develop
Are you sure you want to change the base?
Conversation
5c124eb
to
4cf9d7b
Compare
7f95aab
to
2d6bd8a
Compare
@srikanthccv I didn't remove the old flag |
...ardingContainer/Modules/AwsMonitoring/ECSExternal/md-docs/ecsExternal-createDaemonService.md
Outdated
Show resolved
Hide resolved
@@ -52,6 +52,8 @@ func main() { | |||
flag.StringVar(&cacheConfigPath, "experimental.cache-config", "", "(cache config to use)") | |||
flag.StringVar(&fluxInterval, "flux-interval", "5m", "(cache config to use)") | |||
flag.StringVar(&cluster, "cluster", "cluster", "(cluster name - defaults to 'cluster')") | |||
// Allow using the consistent naming with the signoz collector | |||
flag.StringVar(&cluster, "cluster-name", "cluster", "(cluster name - defaults to 'cluster')") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this override the --cluster
always i.e even if someone provided --cluster=my-cluster
the value would be default cluster
from --cluster-name
arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srikanthccv No, it won't be overridden unless the --cluster-name
is provided since the flag parse was only invoked while the flag name was passed. That said, if users specify:
--cluster ABC
, then the cluster will be ABC--cluster-name DEF
, then the cluster will be DEF--cluster ABC --cluster-name DEF
, then the cluster will be DEF--cluster-name DEF --cluster ABC
, then the cluster will be ABC
8849c42
to
7cb64b6
Compare
Summary
Allow using the consistent ClickHouse cluster name in the collector and query service.
Related Issues / PR's
This resolves SigNoz/signoz-otel-collector#308