Skip to content

Commit

Permalink
fix: don't subscribe to notifications in sk connections
Browse files Browse the repository at this point in the history
@signalk/client subscribes by default to notifications.*.
This is confusing in the first place if the user enters an
explicit subscription and gets more than they subscribed.

Furthermore this wreaks havoc if you have two interconnected
SK servers. Their explicit subscriptions will not create a
loop if they don't touch the same paths, but the default
notifications subscription will if there is even one
active notification.
  • Loading branch information
tkurki committed May 16, 2024
1 parent 6825d7d commit 4748c17
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/streams/mdns-ws.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ function MdnsWs(options) {
port: options.port,
useTLS: options.type === 'wss',
reconnect: true,
notifications: false,
autoConnect: false,
deltaStreamBehaviour,
rejectUnauthorized: !(options.selfsignedcert === true),
Expand Down

0 comments on commit 4748c17

Please sign in to comment.