Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support to DELETE meta data #1728

Merged
merged 6 commits into from
May 11, 2024
Merged

feature: add support to DELETE meta data #1728

merged 6 commits into from
May 11, 2024

Conversation

sbender9
Copy link
Member

@sbender9 sbender9 commented Apr 25, 2024

There is one issue... When there is the same meta data from baseDeltas and from another source (like a plugin). This will delete the plugins meta for that field until restart or the plugin sends it again.

I think we can live with that...?

@sbender9 sbender9 changed the title [WIP] feature: add support to DELETE meta data feature: add support to DELETE meta data Apr 25, 2024
@sbender9 sbender9 marked this pull request as draft April 26, 2024 19:54
@sbender9
Copy link
Member Author

@tkurki if you're ok with this in concept, I'll add some tests...

@tkurki
Copy link
Member

tkurki commented Apr 28, 2024

Makes sense to me

@sbender9 sbender9 marked this pull request as ready for review May 3, 2024 17:30
@sbender9
Copy link
Member Author

sbender9 commented May 4, 2024

why is this test working when I run it by itself? But not when I run all of them?

Somehow I am getting

{"context":"vessels.urn:mrn:signalk:uuid:c0d79334-4e25-4245-8892-54e8ccc8021d","updates":[{"$source":"courseApi","timestamp":"2024-05-04T20:23:24.865Z","values":[{"path":"navigation.course.nextPoint","value":null}]}]}

@tkurki
Copy link
Member

tkurki commented May 9, 2024

Other tests are creating stuff under serverState that creates deltas during server startup, messing up the order of the deltas that the test is getting. There's a new startServer that purges the settings directory before server startup that should be used.

The culprit here is courseApi, that stores the course settings so that they survive server restarts.

@tkurki tkurki merged commit 0756f1d into master May 11, 2024
4 checks passed
@tkurki tkurki deleted the delete-meta-support branch May 11, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants