-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata editing & zones handling #1730
Conversation
For the zones to work we need to either move the zones threshold-state handling logic to server proper or make the plugin use zones data from the server. If the zones editing is going to be in the server admin ui I don't see much point in keeping the plugin around, so integrating the logic in the server seems the best option. |
I enabled building docker container for this branch, so you can check it out with |
I get the "Something went wrong." message in the data browser screen when selecting "zones" from the dropdown. It throws the following error with the console.
Given there is a separate "zones" section it should probably be filtered out from the dropdown list. |
Nice! Fixed in 038a5da |
Don't want to silently disable it, because then users with active configuration would lose their notifications.
Add support for editing metadata and zones handling = raising notifications based on deltas in the server. Previous work with meta deltas with PUT support makes this pretty straightforward.
The goal of this PR is to add the functionality, not be pretty - let's get the initial end2end functionality out there.
Todo: