Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): add jupyter support #6809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MKdir98
Copy link
Contributor

@MKdir98 MKdir98 commented Feb 8, 2024

Background

Changes πŸ—οΈ

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@MKdir98 MKdir98 requested a review from Pwuts as a code owner February 8, 2024 14:56
@github-actions github-actions bot added the size/m label Feb 8, 2024
Copy link

netlify bot commented Feb 8, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 33ac87b
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/65c9d6fae0545d000887a774
😎 Deploy Preview https://deploy-preview-6809--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntindle
Copy link
Member

ntindle commented Feb 8, 2024

I think this is a good start! Would love a Jupyter notebook file with access to autogpt’s loop for modifications and code complete for the issue

@MKdir98
Copy link
Contributor Author

MKdir98 commented Feb 9, 2024

I think this is a good start! Would love a Jupyter notebook file with access to autogpt’s loop for modifications and code complete for the issue

I was just thinking and I think it's good we have a folder as notebooks in agents folder.
It should be in gitignore. we can put some examples. Can we do that? And this is what you want?(a notebook for test?)

@MKdir98
Copy link
Contributor Author

MKdir98 commented Feb 9, 2024

Copy link

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

ntindle
ntindle previously approved these changes Feb 12, 2024
@ntindle
Copy link
Member

ntindle commented Feb 12, 2024

@Pwuts ready for review. Goal is an initial example of notebook in repo, then AutoGPT in one

Copy link

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

@MKdir98
Copy link
Contributor Author

MKdir98 commented Feb 12, 2024

I fixed lint and pushed it again

@Pwuts
Copy link
Member

Pwuts commented Feb 13, 2024

A few initial notes:

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Jupyter notebook can be part of an implementation for #5132 (see comment above). That being said, this PR doesn't address the actual integration with the agent.

Using Jupyter notebooks for quick prototyping and development is definitely useful! But: this should need minimal setup in the repo itself. VSCode has near-builtin support for editing Jupyter notebooks, and there's also Google Colab which allows working on notebooks in git repos.

@MKdir98
Copy link
Contributor Author

MKdir98 commented Feb 13, 2024

A Jupyter notebook can be part of an implementation for #5132 (see comment above). That being said, this PR doesn't address the actual integration with the agent.

Using Jupyter notebooks for quick prototyping and development is definitely useful! But: this should need minimal setup in the repo itself. VSCode has near-builtin support for editing Jupyter notebooks, and there's also Google Colab which allows working on notebooks in git repos.

Oh sorry. I misunderstood this one. I read the issue again, and now I understand it. Let me investigate more about the main task.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Feb 13, 2024
Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/xl
Projects
Status: πŸ‘πŸΌ Mergeable
Development

Successfully merging this pull request may close these issues.

None yet

3 participants