New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sentry error logging #6867
base: master
Are you sure you want to change the base?
Added sentry error logging #6867
Conversation
β Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this on the Sentry integration we already have: https://github.com/Significant-Gravitas/AutoGPT/blob/master/autogpts/autogpt/autogpt/app/telemetry.py
And please run the linters to fix any formatting issues before pushing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong file
@@ -184,7 +190,7 @@ def configure_logging( | |||
json_logger.propagate = False | |||
|
|||
# Disable debug logging from OpenAI library | |||
openai_logger.setLevel(logging.WARNING) | |||
openai_logger.setLevel(logging.INFO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? We don't want all of OpenAI's internal logging to show up in the application log, because it's quite a lot.
level: int = logging.INFO, | ||
log_dir: Path = LOG_DIR, | ||
log_format: Optional[LogFormatName] = None, | ||
log_file_format: Optional[LogFormatName] = None, | ||
plain_console_output: bool = False, | ||
tts_config: Optional[TTSConfig] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad formatting
import sentry_sdk | ||
from sentry_sdk.integrations.logging import LoggingIntegration | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improper placement of 3rd party imports
@@ -9,7 +9,7 @@ | |||
from typing import TYPE_CHECKING, Optional | |||
|
|||
from auto_gpt_plugin_template import AutoGPTPluginTemplate | |||
from openai._base_client import log as openai_logger | |||
from openai.util import logger as openai_logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Background
Changes ποΈ
PR Quality Scorecard β¨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance? β+10 pts