fix(agent): Disable profile generator -> speed up agent setup #7121
+91
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's specified in an OpenAI-specific format, which might adversely affect performance with other providers.
…ace usages with `agent.state.*` This prevents potential state inconsistency between `agent` and `agent.state` when other values are assigned to `agent.ai_profile` and `agent.directives`
- Replace `generate_agent_for_task` by `create_agent` - Make `ai_profile` parameter on `create_agent` optional (use default `AIProfile` if not passed)
✅ Deploy Preview for auto-gpt-docs canceled.
|
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Description updated to latest commit (b0e02fa)
|
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Review
Code feedback:
|
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
![codiumai-pr-agent-pro[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
20
to
21
| if not ai_profile: | ||
| ai_profile = AIProfile() |
There was a problem hiding this comment.
Suggestion: To avoid creating an unnecessary AIProfile instance when ai_profile is already provided, consider using a more efficient conditional assignment. [enhancement]
Suggested change
| if not ai_profile: | |
| ai_profile = AIProfile() | |
| ai_profile = ai_profile or AIProfile() |
Comment on lines
22
to
23
| if not directives: | ||
| directives = AIDirectives.from_file(app_config.prompt_settings_file) |
There was a problem hiding this comment.
Suggestion: Instead of using a simple conditional check for directives, consider using a more Pythonic approach with or to assign default values. [best practice]
Suggested change
| if not directives: | |
| directives = AIDirectives.from_file(app_config.prompt_settings_file) | |
| directives = directives or AIDirectives.from_file(app_config.prompt_settings_file) |
| @@ -156,7 +156,7 @@ def build_system_prompt( | |||
| self.config.body_template.format( | |||
| constraints=format_numbered_list( | |||
| ai_directives.constraints | |||
| + self._generate_budget_constraint(ai_profile.api_budget) | |||
| # + self._generate_budget_constraint(ai_profile.api_budget) | |||
There was a problem hiding this comment.
Suggestion: The commented-out code for generating budget constraints seems to be removed intentionally. If it's no longer needed, consider removing the commented line to clean up the code. [maintainability]
Comment on lines
18
to
23
| class SystemComponent(MessageProvider, CommandProvider): | ||
| """Component for system messages and commands.""" | ||
|
|
||
| def __init__(self, config: Config, profile: AIProfile): | ||
| def __init__(self, config: Config): | ||
| self.legacy_config = config | ||
| self.profile = profile | ||
|
|
||
| def get_constraints(self) -> Iterator[str]: | ||
| if self.profile.api_budget > 0.0: | ||
| yield ( | ||
| f"It takes money to let you run. " | ||
| f"Your API budget is ${self.profile.api_budget:.3f}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Suggestion: The SystemComponent class has been simplified by removing the DirectiveProvider role and associated methods. If the budget-related functionality is no longer needed, this change is appropriate. However, if budget constraints are still relevant, consider reintegrating or handling them differently. [possible issue]
Suggested change
| class SystemComponent(MessageProvider, CommandProvider): | |
| """Component for system messages and commands.""" | |
| def __init__(self, config: Config, profile: AIProfile): | |
| def __init__(self, config: Config): | |
| self.legacy_config = config | |
| self.profile = profile | |
| def get_constraints(self) -> Iterator[str]: | |
| if self.profile.api_budget > 0.0: | |
| yield ( | |
| f"It takes money to let you run. " | |
| f"Your API budget is ${self.profile.api_budget:.3f}" | |
| ) | |
| class SystemComponent(MessageProvider, CommandProvider): | |
| """Component for system messages and commands.""" | |
| def __init__(self, config: Config, profile: AIProfile): | |
| self.legacy_config = config | |
| self.profile = profile | |
| def get_constraints(self) -> Iterator[str]: | |
| if self.profile.api_budget > 0.0: | |
| yield ( | |
| f"It takes money to let you run. " | |
| f"Your API budget is ${self.profile.api_budget:.3f}" | |
| ) |
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. Changelog updates: 2024-05-03Added
Changed
Fixed
|
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Analysis
✨ Usage guide:Using static code analysis capabilities, the Language that are currently supported: Python, Java, C++, JavaScript, TypeScript. |
…tor-on-agent-creation
CI Failure Feedback(Checks updated until commit a94d019)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7121 +/- ##
==========================================
- Coverage 36.05% 35.43% -0.63%
==========================================
Files 19 18 -1
Lines 1273 1222 -51
Branches 182 181 -1
==========================================
- Hits 459 433 -26
+ Misses 786 761 -25
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9 tasks
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
the
conflicts
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Pwuts
force-pushed
the
reinier/open-765-do-not-run-profile-generator-on-agent-creation
branch
from
dee2ff8
to
eb6e386
Compare
…tor-on-agent-creation
Pwuts
force-pushed
the
reinier/open-765-do-not-run-profile-generator-on-agent-creation
branch
from
eb6e386
to
4f30373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
AIProfile.api_budgetattributeagent.ai_profileandagent.directivesattributesType
enhancement, bug_fix
Description
create_agentto handle optional AIProfile, using defaults when not provided.profile_generator.pyfor broader use.generate_agent_for_taskwithcreate_agent.SystemComponentby removing unused directives related to AI profiles.AIProfileto have default values and removed theapi_budgetattribute.api_budgetfromAIProfile.Changes walkthrough
7 files
configurators.py
Refactor create_agent to Handle Optional AIProfileautogpts/autogpt/autogpt/agent_factory/configurators.py
ai_profileparameter optional increate_agentfunction,defaulting to a new
AIProfileinstance if not provided.ai_profileanddirectivesby creatingdefault instances within the function.
profile_generator.py
Simplify and Generalize Example Call in Profile Generatorautogpts/autogpt/autogpt/agent_factory/profile_generator.py
_example_callto a more generalizedformat.
agent.py
Streamline Agent Initialization by Removing Specific Profilesautogpts/autogpt/autogpt/agents/agent.py
ai_profileanddirectivesfrom agent initialization, usingsystem-wide defaults instead.
agent_protocol_server.py
Optimize Agent Creation in Protocol Serverautogpts/autogpt/autogpt/app/agent_protocol_server.py
generate_agent_for_taskwithcreate_agentto streamline agentcreation.
main.py
Use Default AI Profiles in Main Application Flowautogpts/autogpt/autogpt/app/main.py
setup.
profiles.
system.py
Simplify System Component by Removing Unused Directivesautogpts/autogpt/autogpt/commands/system.py
DirectiveProviderimplementation and related methods asai_profileis no longer used here.ai_profile.py
Update AIProfile with Defaults and Remove Budgetautogpts/autogpt/autogpt/config/ai_profile.py
ai_nameandai_roleinAIProfile.api_budgetattribute fromAIProfile.1 files
one_shot.py
Disable Budget Constraint in System Promptautogpts/autogpt/autogpt/agents/prompt_strategies/one_shot.py
1 files
test_ai_profile.py
Update AIProfile Unit Tests for Budget Removalautogpts/autogpt/tests/unit/test_ai_profile.py
api_budgetfromAIProfile.