Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poetry install issue on ARM64 & python 3.12 #7145

Merged
merged 5 commits into from May 14, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented May 11, 2024

Background

Thinc (the inferred dependency of spacy & en-core-web-sm) 8.1.12 is broken on Arm64: explosion/thinc#474.
The scope of this change is to upgrade the existing deps to not use the older version of Thinc to fix the issue.

This should fix:
#7132
#7111
#7080
#6597

Changes 🏗️

Upgraded en-core-web-sm to 3.7.1 and spacy to 3.7.4.

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@majdyz majdyz requested a review from a team as a code owner May 11, 2024 10:36
Copy link

netlify bot commented May 11, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 708d24d
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/663f4a4b322c5c00080470c7

Copy link

netlify bot commented May 11, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit b57e3b1
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66432a963b19180008992eee

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.68%. Comparing base (b0cbf71) to head (b57e3b1).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7145   +/-   ##
=======================================
  Coverage   44.68%   44.68%           
=======================================
  Files         133      133           
  Lines        6315     6315           
  Branches      823      823           
=======================================
  Hits         2822     2822           
  Misses       3382     3382           
  Partials      111      111           
Flag Coverage Δ
Linux 44.60% <ø> (ø)
Windows 42.76% <ø> (ø)
autogpt-agent 44.65% <ø> (ø)
macOS 43.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ntindle
ntindle previously approved these changes May 11, 2024
Pwuts
Pwuts previously requested changes May 13, 2024
autogpts/autogpt/poetry.lock Show resolved Hide resolved
@ntindle ntindle dismissed Pwuts’s stale review May 14, 2024 14:10

Issue Resolved

@ntindle ntindle merged commit 4f81246 into master May 14, 2024
22 checks passed
@ntindle ntindle deleted the zamilmajdy/fix-poetry-arm branch May 14, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants