New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix poetry install issue on ARM64 & python 3.12 #7145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-gpt-docs canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7145 +/- ##
=======================================
Coverage 44.68% 44.68%
=======================================
Files 133 133
Lines 6315 6315
Branches 823 823
=======================================
Hits 2822 2822
Misses 3382 3382
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ntindle
previously approved these changes
May 11, 2024
… zamilmajdy/fix-poetry-arm
…avitas/AutoGPT into zamilmajdy/fix-poetry-arm
Pwuts
previously requested changes
May 13, 2024
ntindle
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Thinc (the inferred dependency of spacy & en-core-web-sm) 8.1.12 is broken on Arm64: explosion/thinc#474.
The scope of this change is to upgrade the existing deps to not use the older version of Thinc to fix the issue.
This should fix:
#7132
#7111
#7080
#6597
Changes 🏗️
Upgraded
en-core-web-sm
to 3.7.1 andspacy
to 3.7.4.PR Quality Scorecard ✨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance?+10 pts