fix(runtime): make require.cache compatible with Object.keys() (jestj…

…s#9848)
SimenB · Apr 20, 2020 · 5179604 · 5179604
1 parent 470ef2d
commit 5179604
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/jest-runtime/src/__tests__/runtime_require_cache.test.js b/packages/jest-runtime/src/__tests__/runtime_require_cache.test.js
@@ -21,8 +21,13 @@ describe('Runtime require.cache', () => {
         runtime.__mockRootPath,
         'RegularModule',
       ).module;
+      const id = regularModule.id;
+      const cache = regularModule.require.cache;
 
-      expect(regularModule.require.cache[regularModule.id]).toBe(regularModule);
+      expect(cache[id]).toBe(regularModule);
+      expect(id in cache).toBeTruthy();
+      expect(Object.keys(cache).includes(id)).toBeTruthy();
+      expect(Object.getOwnPropertyNames(cache).includes(id)).toBeTruthy();
     }));
 
   it('require.cache is tolerant readonly', () =>

diff --git a/packages/jest-runtime/src/index.ts b/packages/jest-runtime/src/index.ts
@@ -1286,8 +1286,15 @@ class Runtime {
         deleteProperty: notPermittedMethod,
         get: (_target, key) =>
           typeof key === 'string' ? this._moduleRegistry.get(key) : undefined,
+        getOwnPropertyDescriptor() {
+          return {
+            configurable: true,
+            enumerable: true,
+          };
+        },
         has: (_target, key) =>
           typeof key === 'string' && this._moduleRegistry.has(key),
+        ownKeys: () => Array.from(this._moduleRegistry.keys()),
         set: notPermittedMethod,
       });
     })();