Merge pull request #13 from SimonGolms/feature/improvements

feat: migrate to ionic v7
SimonGolms · Apr 22, 2023 · 98d58c6 · 98d58c6
2 parents 2204b75 + 52c45cc
commit 98d58c6
Show file tree

Hide file tree

Showing 5 changed files with 6,055 additions and 5,118 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -33,7 +33,7 @@ odsComponentPipeline(
       // The playwright container is based on the Ubuntu-20.04 (focal) image and comes with the latest Node.js v18,
       // as well as all additionally installed dependencies and browser instances.
       // see: https://github.com/microsoft/playwright/blob/main/utils/docker/Dockerfile.focal
-      image: "mcr.microsoft.com/playwright:v1.31.2-focal",
+      image: "mcr.microsoft.com/playwright:v1.32.3-focal",
       name: 'playwright',
       // HINT: Before you increase the resources, make sure that the quotas provide the appropriate resources.
       // resourceLimitCpu: '1',
@@ -251,19 +251,25 @@ def stageAnalyzeCode(def context) {
 }
 
 def stageTest(def context) {
-  container('playwright') {
-    stage('Test Components') {
-      withEnv([
-        'VITE_AZURE_ACTIVE_DIRECTORY_CLIENT_ID=11111111-2222-3333-4444-555555555dev',
-        // IMPORTANT: A valid Azure AD Tenant ID for testing purposes is required.
-        'VITE_AZURE_ACTIVE_DIRECTORY_TENANT_ID=common',
-      ]) {
-        sh(
-          label: 'Test React Components',
-          script: 'npm run test',
-        )
+  try {
+    container('playwright') {
+      stage('Test Components') {
+        withEnv([
+          'VITE_AZURE_ACTIVE_DIRECTORY_CLIENT_ID=11111111-2222-3333-4444-555555555dev',
+          // IMPORTANT: A valid Azure AD Tenant ID for testing purposes is required.
+          'VITE_AZURE_ACTIVE_DIRECTORY_TENANT_ID=common',
+        ]) {
+          sh(
+            label: 'Test React Components',
+            script: 'npm run test',
+          )
+        }
       }
     }
+  } catch (Exception exception) {
+    zip zipFile: "${context.jobName}-${context.tagversion}-playwright-report.zip", archive: true, glob: 'playwright-report/**,test-results/**'
+    echo "\033[31mERROR: The test runs have failed.\033[0m\n\nFor a detailed analysis, download and extract the artifact and view it with: \033[34mnpx --yes @playwright/test show-report\033[0m"
+    throw exception
   }
 }
 

diff --git a/README.md b/README.md
@@ -6,8 +6,8 @@
 [![License: Apache-2.0](https://img.shields.io/github/license/simongolms/ods-quickstarter-fe-ionic-react-vite-playwright?style=for-the-badge)](https://github.com/simongolms/ods-quickstarter-fe-ionic-react-vite-playwright/blob/master/LICENSE)
 [![Maintenance](https://img.shields.io/badge/Maintained%3F-yes-green.svg?style=for-the-badge)](https://github.com/simongolms/ods-quickstarter-fe-ionic-react-vite-playwright/graphs/commit-activity)
 [![Conventional Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-green.svg?style=for-the-badge)](https://conventionalcommits.org)
-![Prerequisite Npm](https://img.shields.io/badge/npm-%3E%3D8.5.5-blue.svg?style=for-the-badge)
-![Prerequisite Node](https://img.shields.io/badge/node-%3E%3D16.15-blue.svg?style=for-the-badge)
+![Prerequisite Npm](https://img.shields.io/badge/npm-%3E%3D9-blue.svg?style=for-the-badge)
+![Prerequisite Node](https://img.shields.io/badge/node-%3E%3D18-blue.svg?style=for-the-badge)
 
 ## Features ✨