Fix shuffle and other issues #616

naveensingh · 2023-10-17T03:56:26Z

Downgrade media3 to 1.1.1. Although 1.2.0-alpha02 has some improvements, it crashes when the app is cold starting (e.g. force-stopped) from the background.
Fix a seek next/previous issue when shuffle mode is enabled. Originally introduced in my previous PR: Playback performance improvements #615
Internally disable skip silence until Toggling skip silence breaks the output androidx/media#712 is resolved (this won't break seamless playback, Playback issues in 5.18.0 #604)

I have reported the media3 crash on the media3 repo so it should only be updated once androidx/media#733 is resolved.

This reverts commit 7a9c5a1.

naveensingh added 4 commits October 17, 2023 07:11

Handle shuffle when lazily seeking to next/previous media items

316bb43

Reduce seek delay to 300

916b7ef

Revert "Update media3 to 1.2.0-alpha02"

d541b05

This reverts commit 7a9c5a1.

Disable skip silence for now

7371d8b

Enable when androidx/media#712 is resolved. See SimpleMobileTools/Simple-Music-Player#604

naveensingh marked this pull request as draft October 17, 2023 03:59

naveensingh marked this pull request as ready for review October 17, 2023 04:12

tibbi merged commit 021666c into SimpleMobileTools:master Oct 17, 2023

naveensingh deleted the fix_shuffle_and_other_issues branch December 27, 2023 05:51

Provide feedback