Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kafka reporter #559

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add kafka reporter #559

wants to merge 2 commits into from

Conversation

lu-xiaoshuang
Copy link
Contributor

This pull request SHALL be merged after 557.

@liuhaoyang
Copy link
Collaborator

Activate this PR. Is there a way to test the accuracy of the kafka data reporting function, or can you provide screenshots for local testing?

@liuhaoyang
Copy link
Collaborator

Also, can you merge #557 and this PR together? then I will review and test the code

@liuhaoyang liuhaoyang self-requested a review October 14, 2023 14:17
@lu-xiaoshuang
Copy link
Contributor Author

Also, can you merge #557 and this PR together? then I will review and test the code

Hi @liuhaoyang, this pull request already contains #557. :-)

@lu-xiaoshuang
Copy link
Contributor Author

Activate this PR. Is there a way to test the accuracy of the kafka data reporting function, or can you provide screenshots for local testing?

Hi @liuhaoyang, here are some snapshots.

segment in kafka message

kafka

traceId: "4493e8179efcd36d936828454c0aa920.15.17035667172280003" traceSegmentId: "4493e8179efcd36d936828454c0aa920.15.17035667172280004" spans { parentSpanId: -1 startTime: 1703566717228 endTime: 1703566717228 operationName: "/home/index" peer: "::1" spanLayer: Http componentId: 3001 tags { key: "url" value: "http://localhost:5000/home/index" } tags { key: "path" value: "/home/index" } tags { key: "http.method" value: "GET" } tags { key: "status_code" value: "200" } } service: "dotnet-service-1" serviceInstance: "a.b.c.d@75ffab866b6344a8bfa80688ddbb8258"

@lu-xiaoshuang
Copy link
Contributor Author

lu-xiaoshuang commented Dec 26, 2023 •
edited

Activate this PR. Is there a way to test the accuracy of the kafka data reporting function, or can you provide screenshots for local testing?

Hi @liuhaoyang , some logs for your reference:

log

@wu-sheng
Copy link
Member

Also, can you merge #557 and this PR together? then I will review and test the code

Hi @liuhaoyang, this pull request already contains #557. :-)

So, we should close #557?

@wu-sheng wu-sheng added the enhancement New feature or request label Dec 26, 2023
@wu-sheng wu-sheng added this to the 2.2.0 milestone Dec 26, 2023
@wu-sheng wu-sheng changed the title add kafka reporter part 2 Add kafka reporter Dec 26, 2023
@wu-sheng wu-sheng modified the milestones: 2.2.0, 2.3.0 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuhaoyang liuhaoyang Awaiting requested review from liuhaoyang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lu-xiaoshuang @liuhaoyang @wu-sheng