[LOOM-1312] [BpkScrollableCalendarGridList] Moved className to existing wrapper div #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://backpack.github.io/storybook-prs/3429 to see this build running in a browser. |
metalix2
reviewed
May 10, 2024
| @@ -123,7 +123,7 @@ const BpkScrollableCalendarGridList = (props: Props) => { | |||
| monthItemHeights[index] || estimatedMonthItemHeight; | |||
|
|
|||
| const rowRenderer = ({ index, style }: { index: number; style: {} }) => ( | |||
| <div style={style}> | |||
| <div className={getClassName('bpk-scrollable-calendar-grid-list__item')} style={style}> | |||
There was a problem hiding this comment.
testing the class's only styling display: inline-table; I don't think it has the effect we expect anymore? Perhaps it's safe to remove?
|
Visit https://backpack.github.io/storybook-prs/3429 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3429 to see this build running in a browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md