[NOJIRA][BpkLoadingButton|BpkCloseButton]: fix loading console errors #3430
Conversation
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers. |
|
Visit https://backpack.github.io/storybook-prs/3430 to see this build running in a browser. |
| }); | ||
|
|
||
| it('should render correctly with a "href" attribute', () => { | ||
| const { asFragment } = render( | ||
| <BpkLoadingButton href="#">My button</BpkLoadingButton>, | ||
| ); | ||
| expect(asFragment()).toMatchSnapshot(); | ||
| expect(error).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should render correctly with a "primaryOnDark" attribute', () => { | ||
| const { asFragment } = render( | ||
| <BpkLoadingButton primaryOnDark>My button</BpkLoadingButton>, |
There was a problem hiding this comment.
Any reason our tests are still doing the old way and not actually using it as it should be?
With one test just working with an attribute?
There was a problem hiding this comment.
The api of BpkLoadingButton hasn't changed, just the underlying implementation.
…#3430) * fix loading button console error * fix close button prop type
…#3430) * fix loading button console error * fix close button prop type
…#3430) * fix loading button console error * fix close button prop type
…#3430) * fix loading button console error * fix close button prop type
Several
console.errormessages caused by incorrect rest statements and prop types fixedRemember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md