Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOOM-1361] [BpkAutoSuggestSuggestion] Added wrapper div around Icon for className prop #3457

Merged
merged 2 commits into from
May 17, 2024

Conversation

Sybsw
Copy link
Contributor

@Sybsw Sybsw commented May 16, 2024

Separating out the div change from #3446 in order to check whether the new accessibility rule violations in storybook are coming from this change or the addition of new storybook addons.
The reason appears to be the latter.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@Sybsw Sybsw added the patch Patch production bug label May 16, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3457 to see this build running in a browser.

Copy link

github-actions bot commented May 16, 2024

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against eab48cb

Copy link

Visit https://backpack.github.io/storybook-prs/3457 to see this build running in a browser.

@Sybsw Sybsw merged commit 41cbe1a into main May 17, 2024
9 checks passed
@Sybsw Sybsw deleted the LOOM-1361_Just_Div branch May 17, 2024 08:24
FireRedNinja pushed a commit that referenced this pull request May 22, 2024
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants