Merge pull request #52 from dominicfraser/npm_9

Support NPM 9.0.0
Skyscanner · Mar 21, 2023 · 0136f0a · 0136f0a
2 parents 5fb3738 + 9546265
commit 0136f0a
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## Unreleased
 
+- Update to support `npm bin` being removed in NPM `9.0.0`
+
 ### Breaking
 - Upgraded to support `lts/gallium` (Node 16)
 

diff --git a/dist/cli.js b/dist/cli.js
diff --git a/dist/index.js b/dist/index.js
diff --git a/index.js b/index.js
@@ -79,7 +79,8 @@ const checkVersion = (engineName, command) => {
   let localVersionValid = null;
 
   try {
-    const localBinFolder = execSync('npm bin').toString().trim();
+    const localRootFolder = execSync('npm root').toString().trim();
+    const localBinFolder = `${localRootFolder}${path.sep}.bin`;
 
     const hasLocalVersion = existsSync(
       `${localBinFolder}${path.sep}${engineName}`,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -10,8 +10,8 @@
     "dist"
   ],
   "engines": {
-    "node": "^16.14.2",
-    "npm": "^8.5.0"
+    "node": "^16.14.2 || ^18.14.1",
+    "npm": "^8.5.0 || ^9.3.1"
   },
   "scripts": {
     "lint": "eslint .",