Adding Gemini Api Integration #150
Conversation
| if SettingsManager.get_settings().ENABLE_GEMINI: | ||
| LLMConfigRegistry.register_config( | ||
| "GEMINI_GPT4V", | ||
| litellm.completion("gpt-4-vision-preview", |
There was a problem hiding this comment.
| litellm.completion("gpt-4-vision-preview", | |
| LLMConfig("gemini/gemini-pro", |
According to this https://litellm.vercel.app/docs/providers/gemini
| @@ -72,3 +72,11 @@ def get_config(cls, llm_key: str) -> LLMRouterConfig | LLMConfig: | |||
| True, | |||
| ), | |||
| ) | |||
| if SettingsManager.get_settings().ENABLE_GEMINI: | |||
| LLMConfigRegistry.register_config( | |||
| "GEMINI_GPT4V", | |||
There was a problem hiding this comment.
| "GEMINI_GPT4V", | |
| "GOOGLE_GEMINI_PRO", |
There was a problem hiding this comment.
Failing When i run
precommit run all-files
There was a problem hiding this comment.
are you running it within an active poetry shell?
first run, poetry shell, then run the precommit command. let me know how it goes
There was a problem hiding this comment.
got this error when running ./run_skyvern.sh
is there any code changes needed others than above mentioned files.
There was a problem hiding this comment.
Yes, we have a check that makes sure at least one provider is enabled. You need to update here as well:
|
I think you also need to do |
|
i have made changes please review |
| @@ -72,3 +74,12 @@ def get_config(cls, llm_key: str) -> LLMRouterConfig | LLMConfig: | |||
| True, | |||
| ), | |||
| ) | |||
| if SettingsManager.get_settings().ENABLE_GEMINI: | |||
| LLMConfigRegistry.register_config( | |||
| "GEMINI_GPT4V", | |||
There was a problem hiding this comment.
| "GEMINI_GPT4V", | |
| "GEMINI_PRO_VISION", |
Co-authored-by: Kerem Yilmaz <kerem@skyvern.com>
Co-authored-by: Kerem Yilmaz <kerem@skyvern.com>
unaisshemim
requested review from
ykeremy,
suchintan,
msalihaltun and
wintonzheng
|
merged |
|
This pull request is stale because it has been open for 14 days with no activity. |
| @@ -61,14 +61,15 @@ class Settings(BaseSettings): | |||
| # LLM Configuration # | |||
| ##################### | |||
| # ACTIVE LLM PROVIDER | |||
| LLM_KEY: str = "OPENAI_GPT4V" | |||
There was a problem hiding this comment.
Can we keep the default llm_key as OPENAI_GPT4V as this is the most reliable model that's been well tested by the skyvern team?
| # COMMON | ||
| LLM_CONFIG_MAX_TOKENS: int = 4096 | ||
| LLM_CONFIG_TEMPERATURE: float = 0 | ||
| # LLM PROVIDER SPECIFIC | ||
| ENABLE_OPENAI: bool = True |
There was a problem hiding this comment.
same. let's keep this True
|
This pull request is stale because it has been open for 14 days with no activity. |
completed Gemin Api Integration on Skyvern