Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pnpm #893

Merged
merged 14 commits into from Feb 16, 2024
Merged

Migrate to pnpm #893

merged 14 commits into from Feb 16, 2024

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Nov 5, 2023 •
edited

I made pnpm work, I also updated documentation in CONTRIBUTING.md on how to activate corepack

@ImUrX ImUrX added Area: GUI Related to the GUI Area: Continuous Integration Automated testing and deployment Type: Enhancement Adds or improves a feature labels Nov 5, 2023
TheDevMinerTV
TheDevMinerTV reviewed Nov 5, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
TheDevMinerTV
TheDevMinerTV reviewed Nov 5, 2023
View reviewed changes
pnpm-workspace.yaml Outdated Show resolved Hide resolved
ButterscotchV
ButterscotchV approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, I have no opinion on npm vs pnpm.

@ImUrX ImUrX merged commit 21576af into main Feb 16, 2024
11 checks passed
@ImUrX ImUrX deleted the pnpm-migration branch February 16, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDevMinerTV TheDevMinerTV TheDevMinerTV left review comments

@Eirenliel Eirenliel Eirenliel approved these changes

@loucass003 loucass003 loucass003 approved these changes

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

@TheButlah TheButlah Awaiting requested review from TheButlah

Assignees
No one assigned
Labels
Area: Continuous Integration Automated testing and deployment Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ImUrX @Eirenliel @loucass003 @ButterscotchV @TheDevMinerTV