Add -c/--fail-on-critical flag to api:validate command
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalemRoelofsSB
requested review from
barryadk,
lukaszantkowiak and
MateuszPol
as code owners
barryadk
previously approved these changes
Mar 9, 2023
CalemRoelofsSB
changed the title
-c/--failOnCritical flag to api:validate command-c/--fail-on-critical flag to api:validate command
lukaszantkowiak
approved these changes
Mar 9, 2023
CalemRoelofsSB
deleted the
feature/add-failOnCritical-flag-to-api-validate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
-c/--fail-on-criticalflag to theapi:validatecommand.When this flag is present, if there are critical standardization errors present in the referenced definition, the CLI with exit with error code
1.Also slight refactor of the existing tests for
api:validatecommand.