fix(deps): update dependencies #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pin log4js@6.3.0 until ESM bug is resolved (see oclif/oclif/issues/695) - remove `generate` command as it was not functional - add missing/remove redundant dependencies from lerna packages
rossiam
approved these changes
Feb 11, 2022
| const readFileMock = (fs.readFileSync as unknown as jest.Mock<Buffer, [fs.PathLike]>) | ||
| .mockImplementation(() => { throw { code: 'ENOENT' } }) | ||
| const writeFileMock = fs.writeFileSync as jest.Mock<typeof fs.writeFileSync> | ||
| const chmodMock = fs.chmod as unknown as jest.Mock<void, [PathLike, string | number, NoParamCallback]> | ||
|
|
||
| const getPortMock = (getPort as unknown as jest.Mock<Promise<number>, [getPort.Options | undefined]>) | ||
| const getPortMock = jest.mocked(getPort) |
There was a problem hiding this comment.
This is awesome...I need to remember to use it from now on!
There was a problem hiding this comment.
Yeah, it was just added in Jest 27. used to be a hidden util in ts-jest.
john-u
commented
Feb 11, 2022
| @@ -57,7 +57,7 @@ export default class ConfigCommand extends SmartThingsCommand { | |||
| ] | |||
| const tableFieldDefinitions: TableFieldDefinition<ConfigItem>[] = [ | |||
| ...listTableFieldDefinitions, | |||
| { label: 'Definition', value: (item) => yaml.safeDump(item.data) }, | |||
| { label: 'Definition', value: (item) => yaml.dump(item.data) }, | |||
There was a problem hiding this comment.
All of these are equivalently "safe". See migration-guide-from-js-yaml3-to-js-yaml4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatecommand as it was not functional