Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Upgrade to lockfileVersion 2 using npm v7 #905

Merged
merged 3 commits into from Apr 19, 2021
Merged

Improvement: Upgrade to lockfileVersion 2 using npm v7 #905

merged 3 commits into from Apr 19, 2021

Conversation

parachvte
Copy link
Contributor

@parachvte parachvte commented Mar 31, 2021 •
edited

As discussed in actions/setup-node#213

npm v7 is brought by Node 15.x, either we

  1. Use node 15.x
  2. Upgrade npm in workflow (<-- what we chose

Upgrading to lockfileVersion@2 will result in file size doubled.

@parachvte parachvte added the Type: Build Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm label Mar 31, 2021
@parachvte parachvte marked this pull request as draft March 31, 2021 10:13
@parachvte parachvte marked this pull request as ready for review April 19, 2021 06:18
@parachvte parachvte merged commit 0625ab6 into Snapmaker:master Apr 19, 2021
@parachvte parachvte deleted the improvement-lockfile branch April 19, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jane-rose jane-rose Awaiting requested review from jane-rose

@meiliang1123 meiliang1123 Awaiting requested review from meiliang1123

Assignees
No one assigned
Labels
Type: Build Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@parachvte