Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back description after revert #1330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Viczei
Copy link
Contributor

@Viczei Viczei commented Mar 25, 2024

This reverts commit 21d8022.

@Viczei Viczei self-assigned this Mar 25, 2024
@Viczei Viczei changed the title fix: Revert "fix: Revert fix: contribution description null (#1303) (#1328)" fix: add back description after revert Mar 25, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai testé la branche, et tout me semble accessible et fonctionnel

@SocialGroovyBot SocialGroovyBot temporarily deployed to review-feat-revert-revert-description-contrib-5qlys9 March 27, 2024 14:29 Destroyed
@m-maillot m-maillot force-pushed the feat/revert-revert-description-contrib branch from 2cc45a6 to f466845 Compare March 27, 2024 14:57
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

🎉 Deployment for commit f466845 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/contributions:sha-f4668451b6ea440e92a073effe35d0b05341dacb
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-f4668451b6ea440e92a073effe35d0b05341dacb
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-f4668451b6ea440e92a073effe35d0b05341dacb
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-f4668451b6ea440e92a073effe35d0b05341dacb
Debug

Copy link
Contributor

@m-maillot m-maillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La requête ne plante pas chez moi mais je ne comprends pas ce qu'elle modifie.

Si je lance la requête :

SELECT * FROM contribution.answers WHERE (content is NULL or content = '') AND content_type != 'NOTHING';

J'obtiens 137 résultats avant lancement de la migration. Après lancement de la migration, j'ai toujours le même nombre 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants