Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prequalifié sans non publié #1387

Merged
merged 2 commits into from May 14, 2024
Merged

fix: prequalifié sans non publié #1387

merged 2 commits into from May 14, 2024

Conversation

Viczei
Copy link
Contributor

@Viczei Viczei commented May 13, 2024

No description provided.

@Viczei Viczei self-assigned this May 13, 2024
@Viczei Viczei linked an issue May 13, 2024 that may be closed by this pull request
[Regression] Une page dépubliée peut être retrouvée en preprod et prod via le moteur de recherche SocialGouv/code-du-travail-numerique#5852
Closed
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

m-maillot
m-maillot reviewed May 13, 2024
View reviewed changes
targets/export-elasticsearch/src/ingester/prequalified/fetchPrequalified.ts Outdated
id
title
variants
documents(order_by: {order: asc}, where: {document: {is_published: { _eq: true} }}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut aussi regarder le is_searchable non ?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

maxgfr
maxgfr approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top !

@github-actions GitHub Actions
Copy link

🎉 Deployment for commit b93207b :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-b93207b32a45681f2e6f900f0d40f284bf1a8ef9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-b93207b32a45681f2e6f900f0d40f284bf1a8ef9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-b93207b32a45681f2e6f900f0d40f284bf1a8ef9
Debug

@Viczei Viczei merged commit af8f634 into master May 14, 2024
30 checks passed
@Viczei Viczei deleted the linked-5852-regression-une-page-dépubliée-peut-être-retrouvée-en-preprod-et-prod-via-le-moteur-de-recherche branch May 14, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-maillot m-maillot m-maillot approved these changes

@maxgfr maxgfr maxgfr approved these changes

@carolineBda carolineBda Awaiting requested review from carolineBda

Assignees

@Viczei Viczei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] Une page dépubliée peut être retrouvée en preprod et prod via le moteur de recherche
4 participants
@Viczei @m-maillot @maxgfr @SocialGroovyBot