Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modele): correction de la création des modèles #1393

Merged
merged 1 commit into from
May 17, 2024

Conversation

m-maillot
Copy link
Contributor

@m-maillot m-maillot commented May 16, 2024

fix: #1395

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

🎉 Deployment for commit d348a3d :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-d348a3df6d68e2061537f1b2f5aeda5b3721b44c
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-d348a3df6d68e2061537f1b2f5aeda5b3721b44c
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-d348a3df6d68e2061537f1b2f5aeda5b3721b44c
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -126,7 +126,7 @@ export class DocumentsService {
): HasuraDocument<any> {
return {
cdtn_id: document?.cdtn_id ?? generateCdtnId(data.title),
initial_id: data.id,
initial_id: data.id!,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du coup, on rajoute ça vu que ça peut être optionnel

@@ -6,7 +6,7 @@ import {
import { fileSchema } from "../common/type";

export const modelSchema = z.object({
id: z.string().uuid(),
id: z.string().uuid().optional(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans quel cas l'id n'est pas défini en fait ? Car sinon on peut modifier le type de base

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il n'est pas présent dans le cas de la création. On peut modifier un autre type en effet, mais hier dans le feu de l'action j'ai été au plus simple.

@m-maillot m-maillot merged commit 0a19d55 into master May 17, 2024
29 checks passed
@m-maillot m-maillot deleted the linked/fix/model-creation branch May 17, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible de créer un modèle
3 participants